Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DB/Creatures): add Intervene spell to Bonechewer Shield Disciple #19949

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix(DB/Creatures): add Intervene spell to Bonechewer Shield Disciple #19949

wants to merge 1 commit into from
+4 −0

Conversation

Grimdhex
Copy link
Contributor

@Grimdhex Grimdhex commented Sep 12, 2024 •
edited
Loading

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

Issues Addressed:

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.
  1. type .tele bt
  2. find bonechewer shield disciple on the way to Gurtogg Bloodboil.
  3. pull and it, and with another charcter move away (8-25y) bonechewer from the rest of the group.
  4. wait to intervene

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@github-actions github-actions bot added the DB related to the SQL database label Sep 12, 2024
@Grimdhex
Copy link
Contributor Author

Grimdhex commented Sep 12, 2024 •
edited
Loading

I put this PR as draft because I need more infos about the behavior (timers and if the target is specific or random. For the moment, I put the cast to closest friendly target).

@Rorschach91
Copy link

This ability probably works like the warrior's spell.
It has 30 seconds cooldown and It only works if one or multiple allies are more than 8 and less than 25 yard away from Bonechewer Shield Disciple.
By the other thing, I don't know if It is randomic, but I think that Bonechewer Shield Disciple gives priority to the ally with less HP.

The problem regarding this ability is that I wasn't able to find a gameplay fight when the mob use Intervene. Usually the players keep the pack united.
Another problem is that I cannot enter in instances on Cata Classic PTR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
DB related to the SQL database
Projects
None yet
Milestone
No milestone
2 participants
@Grimdhex @Rorschach91